Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in runCode (in case loadContract fails) #408

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Fix error handling in runCode (in case loadContract fails) #408

merged 1 commit into from
Jan 4, 2019

Conversation

axic
Copy link
Member

@axic axic commented Dec 12, 2018

No description provided.

@axic axic requested a review from holgerd77 December 12, 2018 10:55
@coveralls
Copy link

coveralls commented Dec 12, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 90.409% when pulling 08079ee on fix-runcode-error into 7169992 on master.

@holgerd77
Copy link
Member

Rebased this.

@axic
Copy link
Member Author

axic commented Jan 4, 2019

@holgerd77 can we merge this?

holgerd77
holgerd77 approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@holgerd77 holgerd77 merged commit 2bb7eb4 into master Jan 4, 2019
@holgerd77 holgerd77 deleted the fix-runcode-error branch January 4, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axic @coveralls @holgerd77 @evertonfraga